Changeset 60524

Timestamp:

07/30/2025 11:01:58 PM (2 months ago)

Author:

peterwilsoncc

Message:

Feeds: Cache RSS feeds in global transients.

Moves the caching of RSS feeds requested via fetch_feed() from single site transients (get|set|delete_transient()) to global transients (get|set|delete_site_transient()).

On multisite installs of WordPress, this replaces per site caching with the global multisite cache to allow a single cache to be shared between all sites. This reduces the amount of data stored in the database and improves performance of feeds when multiple sites are ingesting the same URL.

Props rollybueno, spacedmonkey, peterwilsoncc.
Fixes #63719.

Location:

trunk

Files:

• src/wp-includes/class-wp-feed-cache-transient.php (modified) (6 diffs)
• tests/phpunit/tests/feed/fetchFeed.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-feed-cache-transient.php

@@ -13 +13 @@
  * @since 2.8.0
  * @since 6.7.0 Now properly implements the SimplePie\Cache\Base interface.
+ * @since 6.9.0 Switched to Multisite's global cache via the `*_site_transient()` functions.
  */
 #[AllowDynamicProperties]
@@ -85 +86 @@
         }
 
-        set_transient( $this->name, $data, $this->lifetime );
-        set_transient( $this->mod_name, time(), $this->lifetime );
+        set_site_transient( $this->name, $data, $this->lifetime );
+        set_site_transient( $this->mod_name, time(), $this->lifetime );
         return true;
     }
@@ -98 +99 @@
      */
     public function load() {
-        return get_transient( $this->name );
+        return get_site_transient( $this->name );
     }
 
@@ -109 +110 @@
      */
     public function mtime() {
-        return get_transient( $this->mod_name );
+        return get_site_transient( $this->mod_name );
     }
 
@@ -120 +121 @@
      */
     public function touch() {
-        return set_transient( $this->mod_name, time(), $this->lifetime );
+        return set_site_transient( $this->mod_name, time(), $this->lifetime );
     }
 
@@ -131 +132 @@
      */
     public function unlink() {
-        delete_transient( $this->name );
-        delete_transient( $this->mod_name );
+        delete_site_transient( $this->name );
+        delete_site_transient( $this->mod_name );
         return true;
     }

trunk/tests/phpunit/tests/feed/fetchFeed.php

@@ -59 +59 @@
 
     /**
+     * Ensure that fetch_feed uses the global cache on Multisite.
+     *
+     * @ticket 63719
+     *
+     * @group feed
+     * @group ms-required
+     *
+     * @covers ::fetch_feed
+     * @covers WP_Feed_Cache_Transient
+     */
+    public function test_fetch_feed_uses_global_cache() {
+        $second_blog_id = self::factory()->blog->create();
+
+        $filter = new MockAction();
+        add_filter( 'pre_http_request', array( $filter, 'filter' ) );
+
+        fetch_feed( 'https://wordpress.org/news/feed/' );
+
+        switch_to_blog( $second_blog_id );
+
+        fetch_feed( 'https://wordpress.org/news/feed/' );
+        $this->assertEquals( 1, $filter->get_call_count(), 'The feed cache should be global.' );
+    }
+
+    /**
      * Mock response for `fetch_feed()`.
      *