Hash intermediate file name to avoid ENAMETOOLONG

Hash intermediate file name to avoid ENAMETOOLONG Hash the intermediate Makefile target used for multi-output rules so that it still works when the involved file names are very long. Since the intermediate file's name is effectively arbitrary, this does not come with notable behavioural changes. The `import hashlib` boilerplate is taken directly from `xcodeproj_file.py`. BUG= R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/920ee58c3d3109dea3cd37d88054014891a93db7

[Anna Henningsen, 2016-05-27 22:08:00]

Hash the intermediate Makefile target used for multi-output rules so that it still works when the involved file names are very long. Since the intermediate file's name is effectively arbitrary, this does not come with notable behavioural changes. The `import hashlib` boilerplate is taken directly from `xcodeproj_file.py`.

[thefourtheye, 2016-06-29 19:31:39]

thechargingvolcano@gmail.com changed reviewers: + thechargingvolcano@gmail.com

[thefourtheye, 2016-06-29 19:31:40]

https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py... pylib/gyp/generator/make.py:35: # and other secure hashes. In 2.6, sha is deprecated. Import hashlib if Nit: `sha` is deprecated since 2.5, as per the docs https://docs.python.org/2/library/sha.html

[Anna Henningsen, 2016-06-29 23:54:03]

https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py... pylib/gyp/generator/make.py:35: # and other secure hashes. In 2.6, sha is deprecated. Import hashlib if On 2016/06/29 19:31:40, thefourtheye wrote: > Nit: `sha` is deprecated since 2.5, as per the docs > https://docs.python.org/2/library/sha.html This comment is taken verbatim from `xcodeproj_file.py`, and I believe it is referring to hard deprecation (i.e. with a possible deprecation warning) rather than the docs-only deprecation. Should I update the orignal file too or leave it as it is?

[Anna Henningsen, 2016-10-08 11:02:28]

addaleax@gmail.com changed reviewers: + thakis@chromium.org

[Anna Henningsen, 2016-10-08 11:02:28]

Sorry, not so familiar with the process here, but adding a reviewer now.

[Nico, 2016-10-10 14:59:51]

Generally ok, but: https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py... pylib/gyp/generator/make.py:37: # preserving 2.4 compatibility. I don't think we care about 2.4 compat. I think several pieces in gyp assume we're on 2.7

[Anna Henningsen, 2016-10-11 16:27:07]

I’ve removed the boilerplate and just inserted `import hashlib` instead. On 2016/10/10 14:59:51, Nico wrote: > Generally ok, but: > > https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py > File pylib/gyp/generator/make.py (right): > > https://codereview.chromium.org/2019133002/diff/1/pylib/gyp/generator/make.py... > pylib/gyp/generator/make.py:37: # preserving 2.4 compatibility. > I don't think we care about 2.4 compat. I think several pieces in gyp assume > we're on 2.7 Aye aye, updated with just `import hashlib`.

[Nico, 2016-10-13 13:25:11]

lgtm I'll run tests and land this if they pass. https://codereview.chromium.org/2019133002/diff/40001/pylib/gyp/generator/mak... File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/2019133002/diff/40001/pylib/gyp/generator/mak... pylib/gyp/generator/make.py:1751: intermediate = "%s.intermediate" % (cmddigest) (nit: no need for the parens here)

[Nico, 2016-10-13 13:35:05]

Description was changed from ========== Hash intermediate file name to avoid ENAMETOOLONG Hash the intermediate Makefile target used for multi-output rules so that it still works when the involved file names are very long. Since the intermediate file's name is effectively arbitrary, this does not come with notable behavioural changes. The `import hashlib` boilerplate is taken directly from `xcodeproj_file.py`. BUG= ========== to ========== Hash intermediate file name to avoid ENAMETOOLONG Hash the intermediate Makefile target used for multi-output rules so that it still works when the involved file names are very long. Since the intermediate file's name is effectively arbitrary, this does not come with notable behavioural changes. The `import hashlib` boilerplate is taken directly from `xcodeproj_file.py`. BUG= R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/920ee58c3d3109dea3cd37d88054... ==========

[Nico, 2016-10-13 13:35:06]

Committed patchset #3 (id:40001) manually as 920ee58c3d3109dea3cd37d88054014891a93db7.