asyncio/windows_events.py - Issue 96620044: Optional exception argument to Future.cancel()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: asyncio/windows_events.py

Issue 96620044: Optional exception argument to Future.cancel()

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: asyncio/windows_events.py

===================================================================

--- a/asyncio/windows_events.py

+++ b/asyncio/windows_events.py

@@ -39,12 +39,12 @@

super().__init__(loop=loop)

self.ov = ov

- def cancel(self):

+ def cancel(self, exc=None):

try:

self.ov.cancel()

except OSError:

pass

- return super().cancel()

+ return super().cancel(exc)

class _WaitHandleFuture(futures.Future):

@@ -54,8 +54,8 @@

super().__init__(loop=loop)

self._wait_handle = wait_handle

- def cancel(self):

- super().cancel()

+ def cancel(self, exc=None):

+ super().cancel(exc)

try:

_overlapped.UnregisterWait(self._wait_handle)

except OSError as e:

« no previous file with comments | « asyncio/tasks.py ('k') | no next file » | no next file with comments »