code review 92230043: encoding/xml: add test for EncodeElement

encoding/xml: add test for EncodeElement Update issue 6094

[fabmilo, 2014-05-11 02:34:13]

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

[iant, 2014-05-12 05:46:15]

R=close Please ping this CL after the 1.3 release is out. Thanks.

[fabmilo, 2014-06-12 16:40:55]

Should I create a new CL ? On Sun, May 11, 2014 at 10:46 PM, <iant@golang.org> wrote: > R=close > > Please ping this CL after the 1.3 release is out. Thanks. > > > https://codereview.appspot.com/92230043/ -- LinkedIn: http://linkedin.com/in/fmilo Twitter: @fabmilo Github: http://github.com/Mistobaan/ ----------------------- Simplicity, consistency, and repetition - that's how you get through. (Jack Welch) Perfection must be reached by degrees; she requires the slow hand of time (Voltaire) The best way to predict the future is to invent it (Alan Kay) 

[iant, 2014-07-03 01:07:56]

Testing EncodeElement is a good idea, but this doesn't seem like a great test. The test should not test merely that something was written, it should test that the right data was written.

[fabmilo, 2014-07-07 05:51:54]

Updated with this one https://codereview.appspot.com/110850044 On Thu, Jun 12, 2014 at 9:40 AM, Fabrizio Milo aka misto <mistobaan@gmail.com> wrote: > Should I create a new CL ? > > On Sun, May 11, 2014 at 10:46 PM, <iant@golang.org> wrote: >> R=close >> >> Please ping this CL after the 1.3 release is out. Thanks. >> >> >> https://codereview.appspot.com/92230043/ > > > > -- > LinkedIn: http://linkedin.com/in/fmilo > Twitter: @fabmilo > Github: http://github.com/Mistobaan/ > ----------------------- > Simplicity, consistency, and repetition - that's how you get through. > (Jack Welch) > Perfection must be reached by degrees; she requires the slow hand of > time (Voltaire) > The best way to predict the future is to invent it (Alan Kay) -- LinkedIn: http://linkedin.com/in/fmilo Twitter: @fabmilo Github: http://github.com/Mistobaan/ ----------------------- Simplicity, consistency, and repetition - that's how you get through. (Jack Welch) Perfection must be reached by degrees; she requires the slow hand of time (Voltaire) The best way to predict the future is to invent it (Alan Kay)