code review 89030043: cmd/ld: don't delete output binary if not "ordinary" fi...

cmd/ld: don't delete output binary if not "ordinary" file (redux). following on CL https://codereview.appspot.com/76810045 and issue 7563, i now see there's another "remove(outfile)" a few dozen lines down that also needs fixing.

[mra, 2014-04-17 20:23:46]

Hello golang-codereviews@googlegroups.com (cc: 0intro@gmail.com, iant@golang.org, r@golang.org), I'd like you to review this change to https://code.google.com/p/go

[iant, 2014-04-17 21:03:24]

https://codereview.appspot.com/89030043/diff/40001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): https://codereview.appspot.com/89030043/diff/40001/src/cmd/ld/lib.c#newcode143 src/cmd/ld/lib.c:143: struct stat st; Rather than duplicating the #if, about a static function? static void mayberemoveoutfile() { #if !(defined(_WIN32) || defined(PLAN9)) struct stat st; if (lstat(outfile, &st) == 0 && !S_ISREG(st.st_mode)) return; #endif remove(outfile); }

[mra, 2014-04-18 22:16:01]

Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: 0intro@gmail.com, golang-codereviews@googlegroups.com, r@golang.org), Please take another look.

[iant, 2014-04-18 22:37:20]

LGTM

[iant, 2014-04-18 22:37:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=eef7ccb39676 *** cmd/ld: don't delete output binary if not "ordinary" file (redux). following on CL https://codereview.appspot.com/76810045 and issue 7563, i now see there's another "remove(outfile)" a few dozen lines down that also needs fixing. LGTM=iant R=golang-codereviews, iant CC=0intro, golang-codereviews, r https://codereview.appspot.com/89030043 Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-04-18 22:50:30]

This CL appears to have broken the openbsd-amd64-rootbsd builder. See http://build.golang.org/log/ac92f4d668c8d50be143dee21e2b93fd8333fecf