Issue 824050: Allow latest app version to be dependent on current system version

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 824050: Allow latest app version to be dependent on current system version

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by Greg Robbins

Modified:
10 years, 10 months ago

Reviewers:
TVL

Base URL:
http://google-email-uploader-mac.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -2 lines)			Patch
	M	Source/EmUpAppController.m	View		2 chunks	+72 lines, -2 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm Just wondering, what do you need this for? The downside is when it's time to update, they are dropped on the downloads page, so they must pick the right download. http://codereview.appspot.com/824050/diff/1/2 File Source/EmUpAppController.m (right): http://codereview.appspot.com/824050/diff/1/2#newcode174 Source/EmUpAppController.m:174: BOOL doesMatchHigh = YES; "match" isn't really right here, but I'm not coming up with anything better that isn't a paragraph.

Expand All Messages | Collapse All Messages