Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 8202043: code review 8202043: go.exp/fsnotify: make test more robust if directory was...

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by albert.strasheim
Modified:
11 years, 8 months ago
Reviewers:
nathany, gobot, dave, golang-codereviews
CC:
golang-codereviews
Visibility:
Public.

Description

go.exp/fsnotify: use proper temporary directories in tests

Patch Set 1 #

Patch Set 2 : diff -r c147973839db https://code.google.com/p/go.exp #

Patch Set 3 : diff -r c147973839db https://code.google.com/p/go.exp #

Patch Set 4 : diff -r faab6deef005 https://code.google.com/p/go.exp #

Patch Set 5 : diff -r faab6deef005 https://code.google.com/p/go.exp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -77 lines) Patch
M fsnotify/fsnotify_attrib_test.go View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M fsnotify/fsnotify_test.go View 1 2 3 4 15 chunks +44 lines, -71 lines 0 comments Download

Messages

Total messages: 11
albert.strasheim
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.exp
12 years, 7 months ago (2013-03-30 21:04:25 UTC) #1
dave_cheney.net
Hi, I'm not certain this is the correct fix. Why are the directories present before ...
12 years, 7 months ago (2013-04-01 12:46:14 UTC) #2
albert.strasheim
On 2013/04/01 12:46:14, dfc wrote: > I'm not certain this is the correct fix. Why ...
12 years, 7 months ago (2013-04-01 12:52:15 UTC) #3
dave_cheney.net
> Thanks, I agree. I'll look at fixing it to use ioutil.Tempdir. > > The ...
12 years, 7 months ago (2013-04-01 12:53:47 UTC) #4
albert.strasheim
PTAL
12 years, 6 months ago (2013-04-06 12:30:38 UTC) #5
albert.strasheim
I noticed that TestFsnotifyDeleteWatchedDir is leaking a file descriptor: strace -f -q -e inotify_init,open,close ./fsnotify.test ...
12 years, 6 months ago (2013-04-06 12:43:47 UTC) #6
gobot
Replacing golang-dev with golang-codereviews.
11 years, 10 months ago (2013-12-20 16:21:39 UTC) #7
nathany
On 2013/12/20 16:21:39, gobot wrote: > Replacing golang-dev with golang-codereviews. Chris Howey changed the tests ...
11 years, 9 months ago (2014-01-30 02:57:15 UTC) #8
gobot
R=golang-dev (assigned by dave@cheney.net)
11 years, 9 months ago (2014-01-30 22:36:31 UTC) #9
nathany
On 2013/04/06 12:43:47, albert.strasheim wrote: > I noticed that TestFsnotifyDeleteWatchedDir is leaking a file descriptor: ...
11 years, 9 months ago (2014-02-01 04:26:17 UTC) #10
gobot
11 years, 8 months ago (2014-02-24 01:00:57 UTC) #11
R=close (assigned by dave@cheney.net)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b