Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1468)

Issue 764041: Add Release Notes button to Update alert; change Update destination to Downloads page

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by Greg Robbins
Modified:
10 years, 10 months ago
Reviewers:
TVL
Base URL:
http://google-email-uploader-mac.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M Source/EmUpAppController.m View 2 chunks +12 lines, -4 lines 2 comments Download
M Source/English.lproj/Localizable.strings View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
Greg Robbins
15 years, 7 months ago (2010-03-25 21:34:47 UTC) #1
TVL
lgtm http://codereview.appspot.com/764041/diff/1/2 File Source/EmUpAppController.m (right): http://codereview.appspot.com/764041/diff/1/2#newcode188 Source/EmUpAppController.m:188: urlStr = @"https://code.google.com/p/google-email-uploader-mac/source/browse/trunk/Source/ReleaseNotes.txt"; do you want the revision ...
15 years, 7 months ago (2010-03-26 00:41:01 UTC) #2
Greg Robbins
15 years, 7 months ago (2010-03-26 00:46:17 UTC) #3
http://codereview.appspot.com/764041/diff/1/2 File Source/EmUpAppController.m (right): http://codereview.appspot.com/764041/diff/1/2#newcode188 Source/EmUpAppController.m:188: urlStr = @"https://code.google.com/p/google-email-uploader-mac/source/browse/trunk/Source/ReleaseNotes.txt"; On 2010/03/26 00:41:01, TVL wrote: > do you want the revision history, etc? or would > https://google-email-uploader-mac.googlecode.com/svn/trunk/Source/ReleaseNote... > be a better url? Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b