cmd/cc: allow `quoted` identifiers in assembly input

cmd/cc: allow `quoted` identifiers in assembly input $ cat x.go package main type T int func (t *T) Get() int func main() { t := new(T) *t = 42 println(t.Get()) } $ cat x.s TEXT `·(*T).Get`(SB), 7, $0 MOVQ	p+0(FP), AX MOVQ	0(AX), AX MOVQ	AX, ret+8(FP) RET $ go build -o a.out $ ./a.out 42 $

[Hierro, 2013-08-09 16:47:49]

Is there any chance this could be merged? It would be very useful for increasing the performance of small methods which the compiler is not able to optimize.

[rsc, 2013-08-09 18:14:55]

Not for Go 1.2. We're trying to finish things up, not take new things on. While I understand the desire for the change, I am pretty unhappy with the "API". Russ 

[Hierro, 2013-08-09 18:28:23]

On 2013/08/09 18:14:55, rsc wrote: > Not for Go 1.2. We're trying to finish things up, not take new things on. > While I understand the desire for the change, I am pretty unhappy with the > "API". > > Russ Thanks. I'll bring this up again once 1.2 is released. Regards, Alberto

[r, 2013-10-31 21:03:17]

https://codereview.appspot.com/7492043/diff/5001/src/cmd/cc/lexbody File src/cmd/cc/lexbody (right): https://codereview.appspot.com/7492043/diff/5001/src/cmd/cc/lexbody#newcode393 src/cmd/cc/lexbody:393: if(cp - symb >= NSYMB) check for newline? other control characters? not bother? https://codereview.appspot.com/7492043/diff/5001/src/cmd/cc/lexbody#newcode400 src/cmd/cc/lexbody:400: peekc = IGN; why?

[rsc, 2013-10-31 22:41:31]

I did this as a demo for someone a while back - maybe mtj. I don't intend to submit it. 

[Hierro, 2013-12-02 22:17:34]

On 2013/10/31 22:41:31, rsc wrote: > I did this as a demo for someone a while back - maybe mtj. I don't intend > to submit it. That's a pity, could you reconsider? This a very useful change for performance sensitive code, since it removes a lot of overhead when writing methods in ASM. Regards, Alberto