Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 7343051: code review 7343051: ssh: drain serverChan before signalling EOF

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Jonas Schneider
Modified:
11 years, 9 months ago
Reviewers:
dave, golang-codereviews, bradfitz
Visibility:
Public.

Description

ssh: drain serverChan before signalling EOF Currently, after the server receives EOF from the client, it starts returning EOF immediately on calls to Read(). This fails if there is data left in the read buffer that hasn't been read yet. This patch changes the behaviour to drain the buffer before returning EOF.

Patch Set 1 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ssh/channel.go View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
Jonas Schneider
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
12 years, 8 months ago (2013-02-18 00:59:51 UTC) #1
dave_cheney.net
Thank you for this proposal. Could you please add a test. From memory there should ...
12 years, 8 months ago (2013-02-18 05:01:21 UTC) #2
bradfitz
Q=wait
12 years, 4 months ago (2013-06-17 20:02:41 UTC) #3
gobot
Replacing golang-dev with golang-codereviews.
11 years, 10 months ago (2013-12-20 16:21:41 UTC) #4
dave_cheney.net
11 years, 9 months ago (2014-01-01 23:51:27 UTC) #5
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b