Source/AppleMailItemsController.m - Issue 706041: Skip inserting external parts into Mail.app messages if they're too big

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: Source/AppleMailItemsController.m

Issue 706041: Skip inserting external parts into Mail.app messages if they're too big Base URL: http://google-email-uploader-mac.googlecode.com/svn/trunk/

Patch Set: Created 15 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/AppleMailItemsController.m

===================================================================

--- Source/AppleMailItemsController.m (revision 24)

+++ Source/AppleMailItemsController.m (working copy)

@@ -702,7 +702,8 @@

encoding:NSUTF8StringEncoding

error:&error] autorelease];

unsigned int partFileLen = [fileContents length];

- if (partFileLen > 0) {

+ if (partFileLen > 0

+ && ([emlxString length] + partFileLen) < kMaxMesssageSize) {

// insert the emlxpart as the body of the part's message

// (following the part's header and extra newline)

[emlxString insertString:fileContents

« no previous file with comments | « no previous file | no next file » | no next file with comments »