Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(384)

Issue 70250045: code review 70250045: runtime: update NetBSD/ARM port to EABI.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by minux1
Modified:
11 years, 6 months ago
Visibility:
Public.

Description

runtime: update NetBSD/ARM port to EABI.

Patch Set 1 #

Patch Set 2 : diff -r 63f448126b28 https://code.google.com/p/go #

Patch Set 3 : diff -r 63f448126b28 https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/pkg/runtime/defs_netbsd_arm.h View 1 4 chunks +11 lines, -1 line 1 comment Download

Messages

Total messages: 5
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2014-03-03 08:09:41 UTC) #1
jsing
https://codereview.appspot.com/70250045/diff/40001/src/pkg/runtime/defs_netbsd_arm.h File src/pkg/runtime/defs_netbsd_arm.h (right): https://codereview.appspot.com/70250045/diff/40001/src/pkg/runtime/defs_netbsd_arm.h#newcode4 src/pkg/runtime/defs_netbsd_arm.h:4: #define __ARM_EABI__ Is this generated, or hand edited?
11 years, 7 months ago (2014-03-03 11:48:34 UTC) #2
minux1
On Mar 3, 2014 6:48 AM, <jsing@google.com> wrote: > > > https://codereview.appspot.com/70250045/diff/40001/src/pkg/runtime/defs_netbsd_arm.h > File src/pkg/runtime/defs_netbsd_arm.h ...
11 years, 7 months ago (2014-03-03 18:09:14 UTC) #3
jsing
On 2014/03/03 18:09:14, minux wrote: > On Mar 3, 2014 6:48 AM, <mailto:jsing@google.com> wrote: > ...
11 years, 7 months ago (2014-03-05 15:38:10 UTC) #4
rsc
11 years, 6 months ago (2014-04-17 02:55:49 UTC) #5
R=close 'hg mail' to reopen once 1.3 is out.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b