Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 6998048: Add appengineutil package with OAuth helpers for App Engine

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by jasonhall
Modified:
12 years, 9 months ago
Reviewers:
adg
Visibility:
Public.

Description

Add appengineutil package with OAuth helpers for App Engine

Patch Set 1 #

Patch Set 2 : . #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -0 lines) Patch
A oauth/appengineutil/appengineutil.go View 1 chunk +189 lines, -0 lines 12 comments Download
A oauth/appengineutil/example/app.yaml View 1 1 chunk +8 lines, -0 lines 0 comments Download
A oauth/appengineutil/example/app/app.go View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2
adg
https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineutil.go File oauth/appengineutil/appengineutil.go (right): https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineutil.go#newcode147 oauth/appengineutil/appengineutil.go:147: type datastoreCache struct { You should export this so ...
12 years, 9 months ago (2013-01-08 00:50:56 UTC) #1
adg
12 years, 9 months ago (2013-01-08 00:53:52 UTC) #2
https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineut... File oauth/appengineutil/appengineutil.go (right): https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineut... oauth/appengineutil/appengineutil.go:83: config.RedirectURL = getRedirectURL(c) I think you should export getRedirectURL too, and don't mutate config inside MustOAuth and NewOAuthCallbackHandlerFunc https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineut... oauth/appengineutil/appengineutil.go:118: // Make a local copy of the config. I don't think this is necessary. We can probably rely on the OAuth config being static.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b