code review 69170045: cmd/ld, liblink, pkg/net, pkg/os, pkg/runtime: add supp...

cmd/ld, liblink, pkg/net, pkg/os, pkg/runtime: add support for cgo enabled Android binaries. Android is too similar to Linux to warrant a separate GOOS at this point. Instead, this CL introduces the "android" tag in the standard library to compensate for the differences: - os.TempDir defaults to /data/local/tmp/ instead of /tmp (pkg/os) - getaddrinfo only supports AI_CANONNAME (pkg/net) - TLS emulation (pkg/runtime) To support the TLS emulation implemented by pkg/runtime/asm_tls_android_arm.s and pkg/runtime/cgo/gcc_android.c, the -H android option has been added to cmd/ld. -H android is similar to -H linux with the addition that runtime.tlsgm is turned into a regular variable and that TLS relocations are turned into regular address relocations. misc/cgo/android contains a small test program using an Android specific library through cgo.

[elias.naur, 2014-02-26 19:17:42]

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

[bradfitz, 2014-02-26 19:24:16]

R=rsc,iant https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/tmpdir_unix.go File src/pkg/os/tmpdir_unix.go (right): https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/tmpdir_unix.go#... src/pkg/os/tmpdir_unix.go:5: // +build darwin dragonfly freebsd !android,linux nacl netbsd openbsd solaris linux,!android https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/user/lookup_uni... File src/pkg/os/user/lookup_unix.go (right): https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/user/lookup_uni... src/pkg/os/user/lookup_unix.go:5: // +build darwin dragonfly freebsd !android,linux netbsd openbsd solaris linux,!android

[elias.naur, 2014-02-26 19:39:37]

On 2014/02/26 19:24:16, bradfitz wrote: > R=rsc,iant > > https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/tmpdir_unix.go > File src/pkg/os/tmpdir_unix.go (right): > > https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/tmpdir_unix.go#... > src/pkg/os/tmpdir_unix.go:5: // +build darwin dragonfly freebsd !android,linux > nacl netbsd openbsd solaris > linux,!android > I couldn't get the linux,!android ordering to work. I believe it's caused by pkg/os being a bootstrap package and that cmd/dist handles build tags differently than the full fledged cmd/go. If you like, I could go deeper into cmd/dist to investigate. > https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/user/lookup_uni... > File src/pkg/os/user/lookup_unix.go (right): > > https://codereview.appspot.com/69170045/diff/40001/src/pkg/os/user/lookup_uni... > src/pkg/os/user/lookup_unix.go:5: // +build darwin dragonfly freebsd > !android,linux netbsd openbsd solaris > linux,!android I kept the ordering for consistency.

[rsc, 2014-02-26 20:50:20]

I'm sorry, but no. This is not on the roadmap for Go 1.3 and the feature freeze is days away. I thought I said that on the other thread, but rereading my reply I can see that I didn't quite. What I said about the GOOS in the other thread applies to android support as a whole: if we are going to do this it should be done in a planned, coordinated way from the start of the release cycle, not as a last-minute addition. Not wanting to define a GOOS also means I do not want to define a build tag or start pulling code in that is incomplete and not part of a larger plan. I am very sorry that we have not been able to engage with you much this round. I do expect that we will be able to devote more energy to this in the Go 1.4 cycle. Russ 

[rsc, 2014-04-17 02:34:06]

R=close Please run 'hg mail' after the Go 1.3 release is out and it will reopen this CL for us. Thanks.