Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 6488121: code review 6488121: undo CL 6493071 / 56c7453d488f (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by adg
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, r, dsymonds
Visibility:
Public.

Description

undo CL 6493071 / 56c7453d488f This change messes with anchor links. It obscures the item being linked to. I don't see a way around it. Undoing for now. Fixes issue 4071. ««« original CL description doc css: topbar sticks to the top of large windows. Rationale: for large screens, the convenience of not having to scroll to the top of the page to do a search outweighs having less vertical space. Tested with Chrome, Firefox, Safari with various window and text sizes. R=adg CC=gobot, golang-dev http://codereview.appspot.com/6493071 Committer: Andrew Gerrand <adg@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r cbce1b576493 https://go.googlecode.com/hg #

Patch Set 3 : diff -r cbce1b576493 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M doc/style.css View 1 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
13 years, 1 month ago (2012-09-13 00:46:47 UTC) #1
r
Why does it say "I'd like you to review this change to https://go.googlecode.com/hg"? That's not ...
13 years, 1 month ago (2012-09-13 00:52:24 UTC) #2
adg
Its the old style URL but it still works. It betrays the age of my ...
13 years, 1 month ago (2012-09-13 00:55:15 UTC) #3
dsymonds
LGTM
13 years, 1 month ago (2012-09-13 00:55:58 UTC) #4
adg
13 years, 1 month ago (2012-09-13 01:14:30 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=b3c1f7e35083 *** undo CL 6493071 / 56c7453d488f This change messes with anchor links. It obscures the item being linked to. I don't see a way around it. Undoing for now. Fixes issue 4071. ««« original CL description doc css: topbar sticks to the top of large windows. Rationale: for large screens, the convenience of not having to scroll to the top of the page to do a search outweighs having less vertical space. Tested with Chrome, Firefox, Safari with various window and text sizes. R=adg CC=gobot, golang-dev http://codereview.appspot.com/6493071 Committer: Andrew Gerrand <adg@golang.org> »»» R=golang-dev, r, dsymonds CC=golang-dev http://codereview.appspot.com/6488121
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b