On 2012/08/07 22:24:41, thakis wrote: > +rogerta, as maruel is still on vacation I believe. ...
13 years, 2 months ago (2012-08-20 18:45:07 UTC) #3
On 2012/08/07 22:24:41, thakis wrote: > +rogerta, as maruel is still on vacation I believe. 1. we should fix ico to show up as image properly. 2. Roger, the url (r'^(\d+)/binary/(\d+)/(\d+)/(\d+)$', 'download_binary') should probably upstreamed into the default branch so apply_issue.py would work on codereview.appspot.com. 3. I want to make the instance name and favicon overrideable, I just didn't take the time to do it yet. lgtm but can you email me the file? :D
We have an internal email thread on this. It looks like the new favicon file ...
13 years, 2 months ago (2012-08-20 20:25:40 UTC) #4
We have an internal email thread on this. It looks like the new favicon file doesn't look right in all browsers, and I haven't had the time to check why yet.
On 2012/08/20 20:25:40, thakis wrote: > We have an internal email thread on this. It ...
13 years, 2 months ago (2012-08-20 20:27:27 UTC) #5
On 2012/08/20 20:25:40, thakis wrote: > We have an internal email thread on this. It looks like the new favicon file > doesn't look right in all browsers, and I haven't had the time to check why yet. I sent the icon to MA. I'll add him to the thread as well.
Issue 6443101: Add a HiDPi favicon.ico for chromium's rietveld instance Created 13 years, 2 months ago by thakis Modified 13 years, 2 months ago Reviewers: M-A, Roger Tawa Base URL: Comments: 0