Odd that this uploaded to appspot instead of codereview.chromium.org This can't be landed until after ...
11 years, 8 months ago (2014-02-20 23:39:37 UTC) #1
Odd that this uploaded to appspot instead of codereview.chromium.org This can't be landed until after the merge lands. I'm also not 100% sure it's correct.
FTR, the upstream repo is: https://code.google.com/p/swarming/source/checkout?repo=client So blink moved already? (I must admit I'm a ...
11 years, 8 months ago (2014-02-21 00:03:10 UTC) #2
FTR, the upstream repo is: https://code.google.com/p/swarming/source/checkout?repo=client So blink moved already? (I must admit I'm a bit out of the loop) In theory I'm not sure this is needed at all. What's the issue you are seeing, I could help you debug it.
Nope. Blink has not merged into Chromium yet, but it's coming. I'm preparing the demo ...
11 years, 8 months ago (2014-02-21 00:09:22 UTC) #3
Nope. Blink has not merged into Chromium yet, but it's coming. I'm preparing the demo repository now. I'm not seeing any issues. I did a search replace of "third_party/WebKit" with "blink" and this file was hit. This CL is more of a warning-shot, than something which needs direct action.
Ok thanks, I don't think this line it still technically needed, it's been a long ...
11 years, 8 months ago (2014-02-21 00:57:35 UTC) #4
Ok thanks, I don't think this line it still technically needed, it's been a long time since LayoutTests is optionally checked out so I'll simply remove this line. It happens I can probably remove the other one too, I'll look into it. Thanks for the warning!
Issue 64130045: Fix paths to LayoutTests after the Blink merge. Created 11 years, 8 months ago by eseidel Modified 11 years, 8 months ago Reviewers: M-A Base URL: https://chromium.googlesource.com/external/swarming.client.git@master Comments: 0