Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(502)

Issue 6336051: code review 6336051: encoding/xml: return errors from Encoder's underlying Writer

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by bradfitz
Modified:
13 years, 3 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

encoding/xml: return errors from Encoder's underlying Writer Fixes issue 3773

Patch Set 1 #

Patch Set 2 : diff -r 60041e23de38 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 60041e23de38 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -4 lines) Patch
M src/pkg/encoding/xml/marshal.go View 1 4 chunks +44 lines, -4 lines 0 comments Download
M src/pkg/encoding/xml/marshal_test.go View 1 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2012-06-24 20:07:18 UTC) #1
rsc
This can be done with less code. A bufio.Writer already keeps track of whether an ...
13 years, 4 months ago (2012-06-24 23:24:19 UTC) #2
bradfitz
Yeah, atom did that in his version. On Sun, Jun 24, 2012 at 4:24 PM, ...
13 years, 4 months ago (2012-06-25 06:31:10 UTC) #3
bradfitz
13 years, 3 months ago (2012-07-03 05:06:33 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b