Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(369)

Issue 6295096: code review 6295096: Added RequestSubsystem(), according to RFC 4254 Section...

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by C
Modified:
13 years, 4 months ago
Reviewers:
agl1
CC:
golang-dev, agl1, gpaul
Visibility:
Public.

Description

Added RequestSubsystem(), according to RFC 4254 Section 6.5. It requests the association of a subsystem with the ssh session on the remote host. A subsystem is a predefined command that runs in the background when the ssh session is initiated.

Patch Set 1 #

Patch Set 2 : diff -r 6e3ad7e7a476 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 6e3ad7e7a476 https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 6e3ad7e7a476 https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 6e3ad7e7a476 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M ssh/session.go View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6
C
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, gustav.paul@gmail.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
13 years, 4 months ago (2012-06-18 13:15:32 UTC) #1
agl1
LGTM. I don't see you in AUTHORS. Have you agreed to the CLA? http://golang.org/doc/contribute.html#copyright
13 years, 4 months ago (2012-06-18 14:43:27 UTC) #2
C
On 2012/06/18 14:43:27, agl1 wrote: > LGTM. > > I don't see you in AUTHORS. ...
13 years, 4 months ago (2012-06-18 14:50:08 UTC) #3
agl1
On Mon, Jun 18, 2012 at 10:50 AM, <ChHansmann@gmail.com> wrote: > Sorry, I missed that. ...
13 years, 4 months ago (2012-06-18 14:58:06 UTC) #4
C
Hello golang-dev@googlegroups.com, agl@golang.org (cc: golang-dev@googlegroups.com, gustav.paul@gmail.com), Please take another look.
13 years, 4 months ago (2012-06-18 15:59:28 UTC) #5
agl1
13 years, 4 months ago (2012-06-18 16:12:02 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=7369c049acc1&repo=crypto *** ssh: added RequestSubsystem(). RequestSubsystem requests the association of a subsystem with the ssh session on the remote host. A subsystem is a predefined command that runs in the background when the ssh session is initiated (i.e. sftp). R=golang-dev, agl CC=golang-dev, gustav.paul http://codereview.appspot.com/6295096 Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b