code review 5905063: net: ignore ECONNABORTED from syscall.Accept

net: ignore ECONNABORTED from syscall.Accept Fixes issue 3395.

[dho, 2012-03-26 12:43:14]

Hello rsc@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

[rsc, 2012-03-26 12:56:45]

Thanks, but after Go 1 please. 

[rsc, 2012-03-27 04:05:52]

LGTM I changed my mind about this. It bothers me that this amounts to a packet of death for a Go http server on certain operating systems. (It is not entirely clear to me which operating systems those are.) The change is obviously only affecting err == ECONNABORTED, which we are very badly mishandling now, so it really couldn't get significantly worse. And I believe that "continue" is the correct reaction. So let's run with it. 

[rsc, 2012-03-27 04:06:17]

*** Submitted as 118a2ea28f7e *** net: ignore ECONNABORTED from syscall.Accept Fixes issue 3395. R=rsc, dsymonds CC=golang-dev http://codereview.appspot.com/5905063 Committer: Russ Cox <rsc@golang.org>

[dho, 2012-03-27 05:19:14]

On 2012/03/27 04:05:52, rsc wrote: > LGTM > > I changed my mind about this. It bothers me that this amounts to > a packet of death for a Go http server on certain operating systems. > (It is not entirely clear to me which operating systems those are.) > > The change is obviously only affecting err == ECONNABORTED, > which we are very badly mishandling now, so it really couldn't > get significantly worse. And I believe that "continue" is the correct > reaction. So let's run with it. Ok. FWIW, FreeBSD and Linux at least. Windows probably, but I couldn't test it, and anecdotally it behaves the same as FreeBSD.

[remyoudompheng, 2013-07-20 07:24:42]

R=close

[bradfitz, 2013-07-20 19:28:51]

You don't have to send email for these close comments. Qopher notices the issue modtime and rechecks the comments. It doesn't read incoming email. On Jul 20, 2013 12:24 AM, <remyoudompheng@gmail.com> wrote: > R=close > > https://codereview.appspot.**com/5905063/<https://codereview.appspot.com/5905... > > -- > > ---You received this message because you are subscribed to the Google > Groups "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou... > . > For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o... > . > > > 

[rsc, 2013-07-23 14:07:51]

Can qohper please only consider things that still have reviewers, or things that don't say *** Submitted *** in the CL comments? The hg submit moves everyone to the CC line and posts the comment. There's no point in humans doing anything at that point, not even whatever generates R=close.