Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(245)

Issue 5905063: code review 5905063: net: ignore ECONNABORTED from syscall.Accept

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by dho
Modified:
12 years, 3 months ago
Reviewers:
rsc, bradfitz
CC:
rsc, dsymonds, golang-dev
Visibility:
Public.

Description

net: ignore ECONNABORTED from syscall.Accept Fixes issue 3395.

Patch Set 1 #

Patch Set 2 : diff -r 0b3b5914a3c2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0b3b5914a3c2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/net/fd.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9
dho
Hello rsc@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2012-03-26 12:43:14 UTC) #1
rsc
Thanks, but after Go 1 please.
13 years, 7 months ago (2012-03-26 12:56:45 UTC) #2
rsc
LGTM I changed my mind about this. It bothers me that this amounts to a ...
13 years, 7 months ago (2012-03-27 04:05:52 UTC) #3
rsc
*** Submitted as 118a2ea28f7e *** net: ignore ECONNABORTED from syscall.Accept Fixes issue 3395. R=rsc, dsymonds ...
13 years, 7 months ago (2012-03-27 04:06:17 UTC) #4
dho
On 2012/03/27 04:05:52, rsc wrote: > LGTM > > I changed my mind about this. ...
13 years, 7 months ago (2012-03-27 05:19:14 UTC) #5
remyoudompheng
R=close
12 years, 3 months ago (2013-07-20 07:24:42 UTC) #6
bradfitz
You don't have to send email for these close comments. Qopher notices the issue modtime ...
12 years, 3 months ago (2013-07-20 19:28:51 UTC) #7
remyoudompheng
12 years, 3 months ago (2013-07-20 21:30:11 UTC) #8
rsc
12 years, 3 months ago (2013-07-23 14:07:51 UTC) #9
Can qohper please only consider things that still have reviewers, or things that don't say *** Submitted *** in the CL comments? The hg submit moves everyone to the CC line and posts the comment. There's no point in humans doing anything at that point, not even whatever generates R=close. 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b