src/pkg/encoding/csv/reader.go - Issue 5729068: code review 5729068: csv: clarify what a negative FieldsPerRecord means

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/encoding/csv/reader.go

Issue 5729068: code review 5729068: csv: clarify what a negative FieldsPerRecord means

Patch Set: diff -r 1548900b2e6c https://go.googlecode.com/hg/ Created 13 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/encoding/csv/reader.go

===================================================================

--- a/src/pkg/encoding/csv/reader.go

+++ b/src/pkg/encoding/csv/reader.go

@@ -92,7 +92,8 @@

// If FieldsPerRecord is positive, Read requires each record to

// have the given number of fields. If FieldsPerRecord is 0, Read sets it to

// the number of fields in the first record, so that future records must

-// have the same field count.

+// have the same field count. If FieldsPerRecord is negative, no check is

+// made and records may have a variable number of fields.

// If LazyQuotes is true, a quote may appear in an unquoted field and a

// non-doubled quote may appear in a quoted field.

« no previous file with comments | « no previous file | no next file » | no next file with comments »