Issue 5712054: Support repeated enum arguments for clients built by discovery.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5712054: Support repeated enum arguments for clients built by discovery.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by craigcitro-work

Modified:
13 years, 7 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : (Forgot to remove debugging from previous change) #

Total comments: 2

Patch Set 3 : Support repeated enum arguments for clients built by discovery. #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -7 lines)			Patch
M	apiclient/discovery.py	View		1 chunk	+13 lines, -4 lines	0 comments	Download
M	tests/data/zoo.json	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/test_discovery.py	View	1 2	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Committed at http://code.google.com/p/google-api-python-client/source/detail?r=52d93d6452f... On 2012/03/01 19:57:23, jcgregorio_google wrote: > lgtm > > On 2012/03/01 19:55:49, craigcitro-work wrote: > > PTAL > > > > http://codereview.appspot.com/5712054/diff/1005/tests/test_discovery.py > > File tests/test_discovery.py (right): > > > > > http://codereview.appspot.com/5712054/diff/1005/tests/test_discovery.py#newco... > > tests/test_discovery.py:177: er=['one', 'three'], rr=['foo', 'bar']) > > On 2012/03/01 19:46:09, jcgregorio_google wrote: > > > Also add a test case where you have multiple enums passed in and one of them > > > does not match. > > > > Done!

Expand All Messages | Collapse All Messages