Issue 5667: Add Mark NonFeasible script and make Tools dir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5667: Add Mark NonFeasible script and make Tools dir

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 1 month ago by dmaclach

Modified:
16 years, 3 months ago

Reviewers:
TVL

Base URL:
http://coverstory.googlecode.com/svn/trunk/

Visibility:
Public.

Description

I moved the enablegcov.scpt from the trunk into Tools. Once I check this in I will need to update the webpage as well.

Patch Set 1 #

Created: 17 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, --1 lines)			Patch
		EnableGCov.scpt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
		Tools/MarkAsCodeCoverageNonFeasible.py	View		1 chunk	+48 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hm, diffs don't really look like you moved the scpt, but that might just be a limit in rietveld (file a bug on it?) LGTM http://codereview.appspot.com/5667/diff/1/2 File Tools/MarkAsCodeCoverageNonFeasible.py (right): http://codereview.appspot.com/5667/diff/1/2#newcode48 Line 48: main() this line looks like it might use a tab to indent instead of spaces like the rest of the file. missing a newline at the end?

Expand All Messages | Collapse All Messages