Added Juju Amulet tests for memcached charm.

Added Juju Amulet tests for memcached charm. Added a deploy test, testing memcached with telnet, and configuration test. https://code.launchpad.net/~mbruzek/charms/precise/memcached/trunk/+merge/203565 (do not edit description out of merge proposal)

[mbruzek, 2014-01-28 15:19:36]

Please take a look.

[lazypower, 2014-01-28 15:34:53]

Matt, Thank you for your work on this charm test suite, it looks comprehensive enough to be comfortable, the only issue I found was in the setup script there were missing dependencies. Correct those issues and you get a +1 from me https://codereview.appspot.com/55950045/diff/1/tests/00_setup.sh File tests/00_setup.sh (right): https://codereview.appspot.com/55950045/diff/1/tests/00_setup.sh#newcode13 tests/00_setup.sh:13: sudo apt-get install -y amulet This is missing python3, and any associated python3 libraries to complete the test run. The assumption is we are running this test on a machine with nothing more than juju-core on it. https://codereview.appspot.com/55950045/diff/1/tests/10_deploy_test.py File tests/10_deploy_test.py (right): https://codereview.appspot.com/55950045/diff/1/tests/10_deploy_test.py#newcode65 tests/10_deploy_test.py:65: try: I like how you did this test. +1 https://codereview.appspot.com/55950045/diff/1/tests/10_deploy_test.py#newcod... tests/10_deploy_test.py:137: message = 'The memcached charm passed the deply tests!' Typo on Deploy

[mbruzek, 2014-01-28 16:19:25]

Please take a look.

[mbruzek, 2014-01-28 16:21:14]

I updated the code to respond to lazypower's code review comments.

[Marco Ceppi, 2014-01-31 11:36:25]

This looks good as a test, needs some additional robustness, see inline comments https://codereview.appspot.com/55950045/diff/20001/tests/10_deploy_test.py File tests/10_deploy_test.py (right): https://codereview.appspot.com/55950045/diff/20001/tests/10_deploy_test.py#ne... tests/10_deploy_test.py:96: except: It would be nice if you used except Exception as e: which would allow you to use the e to detail which of the areas failed in the test. So for your message you could add a third option, str(e) to get the message of the error which caused the exception. This should help show authors why the charm is failing if it fails https://codereview.appspot.com/55950045/diff/20001/tests/10_deploy_test.py#ne... tests/10_deploy_test.py:133: relation = mediawiki_unit.relation('cache', 'memcached:cache') The cache relation for memcache sends host, port, and udp-port with the last two being configurable. You should set these to non-standard ports in the initial configuration and test that the values are sent on the wire properly.

[mbruzek, 2014-01-31 20:22:35]

Please take a look.

[Marco Ceppi, 2014-02-04 18:04:30]

LGTM, with one minor fix below https://codereview.appspot.com/55950045/diff/40001/tests/10_deploy_test.py File tests/10_deploy_test.py (right): https://codereview.appspot.com/55950045/diff/40001/tests/10_deploy_test.py#ne... tests/10_deploy_test.py:62: port_string = memcached_unit.info['open-ports'][0] It'd be better to use configuration['tcp-port'] for this, instead of querying the unit.info data.

[mbruzek, 2014-02-06 18:10:49]

Please take a look.