src/pkg/net/http/cookie.go - Issue 5565043: code review 5565043: time: add default location parameter to time.Parse

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/net/http/cookie.go

Issue 5565043: code review 5565043: time: add default location parameter to time.Parse

Patch Set: diff -r b372a927701e https://go.googlecode.com/hg/ Created 13 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/net/http/cookie.go

===================================================================

--- a/src/pkg/net/http/cookie.go

+++ b/src/pkg/net/http/cookie.go

@@ -107,9 +107,9 @@

continue

case "expires":

c.RawExpires = val

- exptime, err := time.Parse(time.RFC1123, val)

+ exptime, err := time.Parse(time.RFC1123, nil, val)

if err != nil {

- exptime, err = time.Parse("Mon, 02-Jan-2006 15:04:05 MST", val)

+ exptime, err = time.Parse("Mon, 02-Jan-2006 15:04:05 MST", nil, val)

if err != nil {

c.Expires = time.Time{}

break

« no previous file with comments | « src/pkg/encoding/asn1/asn1.go ('k') | src/pkg/net/http/fs.go » ('j') | no next file with comments »