Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(355)

Issue 5504058: code review 5504058: log/syslog: add Alert()

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by vadik
Modified:
13 years, 10 months ago
Reviewers:
rsc, mikio
CC:
mikio, rsc, golang-dev
Visibility:
Public.

Description

log/syslog: add Alert() Alert logs a message using the LOG_ALERT priority.

Patch Set 1 #

Patch Set 2 : diff -r 5795c64ddd2a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5795c64ddd2a https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 9fdb7601da95 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/pkg/log/syslog/syslog.go View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6
vadik
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2011-12-21 16:34:52 UTC) #1
mikio
Please add "Fixes..." line to the body of description. On 2011/12/21 16:34:52, vadik wrote: > ...
13 years, 10 months ago (2011-12-22 10:59:06 UTC) #2
rsc
LGTM I looked in the man page and it appears that this is the only ...
13 years, 10 months ago (2011-12-22 19:28:46 UTC) #3
vadik
Hello mikioh.mikioh@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-12-25 15:29:33 UTC) #4
mikio
LGTM I'll submit with "Fixes issue 2325" line.
13 years, 10 months ago (2011-12-26 00:32:20 UTC) #5
mikio
13 years, 10 months ago (2011-12-26 00:34:28 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=17cf5cbe5465 *** log/syslog: add Alert method Alert logs a message using the LOG_ALERT priority. Fixes issue 2325. R=mikioh.mikioh, rsc CC=golang-dev http://codereview.appspot.com/5504058 Committer: Mikio Hara <mikioh.mikioh@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b