Issue 5303093: Add all GAN samples, bring them up to date

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5303093: Add all GAN samples, bring them up to date

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by Luke Blanshard

Modified:
13 years, 11 months ago

Reviewers:
jcgregorio_google

CC:
apasha

Visibility:
Public.

More Reviews

Patch Set 1 #

Created: 13 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+647 lines, -56 lines)			Patch
A	samples/gan/README.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	samples/gan/advertisers/advertisers.py	View	1 chunk	+189 lines, -0 lines	0 comments	Download
A	samples/gan/advertisers/advertisers_template.html	View	1 chunk	+85 lines, -0 lines	0 comments	Download
M	samples/gan/ccoffers/offers.py	View	5 chunks	+34 lines, -24 lines	0 comments	Download
M	samples/gan/ccoffers/offers_template.html	View	4 chunks	+28 lines, -10 lines	0 comments	Download
A	samples/gan/client_secrets.json	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	samples/gan/events/events.py	View	6 chunks	+37 lines, -22 lines	0 comments	Download
A	samples/gan/publishers/publishers.py	View	1 chunk	+188 lines, -0 lines	0 comments	Download
A	samples/gan/publishers/publishers_template.html	View	1 chunk	+73 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

On Fri, Nov 11, 2011 at 11:29 AM, Joe Gregorio <jcgregorio@google.com>wrote: > I just added you as a committer to the project, so you can commit that > code. > Cool, thanks! Luke > > Thanks, > -joe > > On Fri, Nov 11, 2011 at 12:26 PM, Luke Blanshard <leadpipe@google.com> > wrote: > > Thanks Joe. I'm ignorant of the process for codesite, is the next step > mine > > or yours? > > Luke > > > > On Fri, Nov 11, 2011 at 11:22 AM, <jcgregorio@google.com> wrote: > >> > >> LGTM > >> > >> http://codereview.appspot.com/5303093/ > > > > >

Expand All Messages | Collapse All Messages