Let OAuth2Decorator take a list of scopes

[jcgregorio_google, 2011-10-14 18:05:02]

Also, multistore_file.py will also need to be updated. http://codereview.appspot.com/5277045/diff/1/oauth2client/client.py File oauth2client/client.py (right): http://codereview.appspot.com/5277045/diff/1/oauth2client/client.py#newcode740 oauth2client/client.py:740: scope: string, Space separated list of scopes. Update docs here also. http://codereview.appspot.com/5277045/diff/1/oauth2client/client.py#newcode782 oauth2client/client.py:782: scope: string, scope of the credentials being requested. I was going to say update the docs here, but OAuth2WebServerFlowFromClientSecrets is never used, so could you delete this class as part of your CL.

[jasonhall, 2011-10-14 18:08:41]

http://codereview.appspot.com/5277045/diff/1/oauth2client/client.py File oauth2client/client.py (right): http://codereview.appspot.com/5277045/diff/1/oauth2client/client.py#newcode740 oauth2client/client.py:740: scope: string, Space separated list of scopes. On 2011/10/14 18:05:02, jcgregorio_google wrote: > Update docs here also. Done. http://codereview.appspot.com/5277045/diff/1/oauth2client/client.py#newcode782 oauth2client/client.py:782: scope: string, scope of the credentials being requested. On 2011/10/14 18:05:02, jcgregorio_google wrote: > I was going to say update the docs here, but > OAuth2WebServerFlowFromClientSecrets is never used, so could you delete this > class as part of your CL. Done.

[jcgregorio_google, 2011-10-14 19:01:08]

http://codereview.appspot.com/5277045/diff/5002/oauth2client/multistore_file.py File oauth2client/multistore_file.py (right): http://codereview.appspot.com/5277045/diff/5002/oauth2client/multistore_file.... oauth2client/multistore_file.py:92: _multistores_lock.release() Looks like you need to do ''.join() here. Also update test_oauth2client_file.py to use multiple scopes in the unit tests.

[jasonhall, 2011-10-14 19:08:01]

http://codereview.appspot.com/5277045/diff/5002/oauth2client/multistore_file.py File oauth2client/multistore_file.py (right): http://codereview.appspot.com/5277045/diff/5002/oauth2client/multistore_file.... oauth2client/multistore_file.py:92: _multistores_lock.release() On 2011/10/14 19:01:08, jcgregorio_google wrote: > Looks like you need to do ''.join() here. > > Also update test_oauth2client_file.py to use multiple scopes in the unit tests. Done.

[jcgregorio_google, 2011-10-14 19:10:37]

LGTM

[jcgregorio_google, 2011-10-14 19:12:50]

On 2011/10/14 19:10:37, jcgregorio_google wrote: > LGTM Committed in http://code.google.com/p/google-api-python-client/source/detail?r=5cb8f07fd14...

[jcgregorio_google, 2011-10-14 19:12:59]

Thanks!

[jasonhall, 2011-10-14 19:13:17]

No, thank *you* :) On Fri, Oct 14, 2011 at 3:12 PM, <jcgregorio@google.com> wrote: > Thanks! > > http://codereview.appspot.com/**5277045/<http://codereview.appspot.com/5277045/> >