Add shared model for Provisoning and cmdLine Provisioning sample

[yanivi, 2011-10-11 11:26:58]

Ravi, would you kindly review this?

[rmistry, 2011-10-15 22:40:02]

http://codereview.appspot.com/5235058/diff/1/provisioning-cmdline-sample/.cla... File provisioning-cmdline-sample/.classpath (right): http://codereview.appspot.com/5235058/diff/1/provisioning-cmdline-sample/.cla... provisioning-cmdline-sample/.classpath:3: <classpathentry kind="src" output="target/classes" path="src/main/java"/> Dont think you need the output="target/classes" http://codereview.appspot.com/5235058/diff/1/provisioning-cmdline-sample/.cla... provisioning-cmdline-sample/.classpath:5: <classpathentry exported="true" kind="con" path="org.maven.ide.eclipse.MAVEN2_CLASSPATH_CONTAINER"/> Dont think you need the exported="true" http://codereview.appspot.com/5235058/diff/1/provisioning-cmdline-sample/.set... File provisioning-cmdline-sample/.settings/org.eclipse.jdt.core.prefs (right): http://codereview.appspot.com/5235058/diff/1/provisioning-cmdline-sample/.set... provisioning-cmdline-sample/.settings/org.eclipse.jdt.core.prefs:1: #Fri Sep 30 16:37:53 PDT 2011 Could you please copy the contents of the .settings directory of one of the other samples and put it in this directory. Eg: http://code.google.com/p/google-api-java-client/source/browse/picasa-cmdline-... http://codereview.appspot.com/5235058/diff/1/provisioning-cmdline-sample/src/... File provisioning-cmdline-sample/src/main/java/com/google/api/services/samples/provisioning/cmdline/ProvisioningSample.java (right): http://codereview.appspot.com/5235058/diff/1/provisioning-cmdline-sample/src/... provisioning-cmdline-sample/src/main/java/com/google/api/services/samples/provisioning/cmdline/ProvisioningSample.java:77: */ Remove if unneeded. If needed then please add a comment why it is here. http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... File shared/gdata/shared-sample-provisioning/.classpath (right): http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/.classpath:3: <classpathentry kind="src" output="target/classes" path="src/main/java"/> output="target/classes" not needed http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... File shared/gdata/shared-sample-provisioning/.settings/org.eclipse.jdt.core.prefs (right): http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/.settings/org.eclipse.jdt.core.prefs:1: #Fri Sep 30 19:29:58 PDT 2011 Same comment as before for .settings http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... File shared/gdata/shared-sample-provisioning/pom.xml (right): http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/pom.xml:1: <project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> Looks like Entry.class accidentally made it into this CL. Please remove it. http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/pom.xml:12: <url>http://code.google.com/p/google-api-java-client/</url> Can you also add: <issueManagement> <system>code.google.com</system> <url>http://code.google.com/p/google-api-java-client/issues/list</url> </issueManagement> and <inceptionYear>2011</inceptionYear> http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... File shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningClient.java (right): http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningClient.java:5: //import com.google.api.client.googleapis.auth.oauth2.draft10.GoogleAccessProtectedResource; Please delete http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningClient.java:17: /** Perhaps add a javadoc: "Client for the Provisioning Data API." http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningClient.java:29: * @param requestFactory Please delete javadoc if we have nothing to add, same comment applies to the rest of the models. http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningClient.java:47: String familyName, int quota, Boolean suspend, Boolean admin) Boolean admin) { http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... File shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningRequest.java (right): http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningRequest.java:29: }*/ Please remove. http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... File shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningUrl.java (right): http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/ProvisioningUrl.java:76: return new ProvisioningUrl(ROOT_URL + "group/2.0/" + domain + "/" + groupId + "/member/" + memberId ); line > 100 http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... File shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/model/Link.java (right): http://codereview.appspot.com/5235058/diff/1/shared/gdata/shared-sample-provi... shared/gdata/shared-sample-provisioning/src/main/java/com/google/api/services/provisioning/model/Link.java:22: * @author shraddhag@google.com (Your Name Here) Your Name Here