Provisioning patch

[alainv, 2011-09-28 08:39:57]

Hey Shraddha, Overall, good patch :-). Some comments and make sure to test your model against the API. Also, most of the provisioning entries look the same as they are regular atom:entry with a list of apps:property. Maybe you could have a single AppsEntry that extends Entry or BatchEntry and use this instead of duplicating this class everywhere. Best, Alain http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... File src/com/google/api/data/provisioning/v2/model/GroupList.java (right): http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... src/com/google/api/data/provisioning/v2/model/GroupList.java:16: @Key("@entry") This should be: @Key("entry") Entry is an element not an attribute. http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... File src/com/google/api/data/provisioning/v2/model/GroupMember.java (right): http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... src/com/google/api/data/provisioning/v2/model/GroupMember.java:13: public class GroupMember { Shouldn't this extend "Entry" or "BatchEntry" (only if the feed supports batching). http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... src/com/google/api/data/provisioning/v2/model/GroupMember.java:17: public Property[] property; Make it a List<Property>. http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... File src/com/google/api/data/provisioning/v2/model/GroupMemberList.java (right): http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... src/com/google/api/data/provisioning/v2/model/GroupMemberList.java:12: public class GroupMemberList { Extend Feed or BatchFeed. http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... src/com/google/api/data/provisioning/v2/model/GroupMemberList.java:15: @Key("@entry") @Key("entry") http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... File src/com/google/api/data/provisioning/v2/model/User.java (right): http://codereview.appspot.com/5141050/diff/1/src/com/google/api/data/provisio... src/com/google/api/data/provisioning/v2/model/User.java:19: public Category category; Is Category an attribute or an element of a UserEntry? If this is an element and belongs to an atom:entry, please add this in Entry instead.