Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(641)

Issue 49430044: Update job status based just on the final job result

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by phajdan.jr
Modified:
11 years, 9 months ago
Reviewers:
iannucci
CC:
M-A
Visibility:
Public.

Description

Update job status based just on the final job result This is especially useful for try jobs where some step failures are not fatal (e.g. recipe-based builders that deapply the patch and retry failing tests).

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M codereview/views_chromium.py View 2 chunks +0 lines, -10 lines 0 comments Download
M templates/patchset.html View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5
phajdan.jr
Please see http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/87 for an example. The tryserver box on Rietveld shows up as red, ...
11 years, 9 months ago (2014-01-14 21:54:54 UTC) #1
iannucci
+M-A for FYI This looks good to me, just 1 question. https://codereview.appspot.com/49430044/diff/1/templates/patchset.html File templates/patchset.html (right): ...
11 years, 9 months ago (2014-01-17 00:48:53 UTC) #2
phajdan.jr
https://codereview.appspot.com/49430044/diff/1/templates/patchset.html File templates/patchset.html (right): https://codereview.appspot.com/49430044/diff/1/templates/patchset.html#newcode115 templates/patchset.html:115: {%if try_job.url %} On 2014/01/17 00:48:53, iannucci wrote: > ...
11 years, 9 months ago (2014-01-17 01:03:09 UTC) #3
iannucci
Makes sense to me. LGTM.
11 years, 9 months ago (2014-01-17 01:04:00 UTC) #4
iannucci
11 years, 9 months ago (2014-01-25 15:44:48 UTC) #5
On 2014/01/17 01:04:00, iannucci wrote: > Makes sense to me. LGTM. Committed as https://code.google.com/p/rietveld/source/detail?r=4da88725d511fb4d19260aab7e...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b