added never_spam, forward_to, should_trash, should_star to Email settings client

[Claudio Cherubino, 2011-07-18 18:21:37]

http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/cli... File src/gdata/apps/emailsettings/client.py (right): http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/cli... src/gdata/apps/emailsettings/client.py:193: message to "Spam" if it matches the specified filter criteria. this should be "Trash" and not "Spam" http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... File src/gdata/apps/emailsettings/data.py (right): http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... src/gdata/apps/emailsettings/data.py:130: looks like there is some extra whitespace here and below. Did you run glint on the files? http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... src/gdata/apps/emailsettings/data.py:506: message to "Spam" if it matches the specified filter criteria. s/Spam/Trash http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... src/gdata/apps/emailsettings/data.py:533: if forward_to is not None: use: if forward_to:

[manoochehri, 2011-07-18 23:14:11]

On 2011/07/18 21:48:25, manoochehri wrote: Updated relevant files (see patch)

[Claudio Cherubino, 2011-07-18 23:17:51]

On 2011/07/18 23:14:11, manoochehri wrote: > On 2011/07/18 21:48:25, manoochehri wrote: > > Updated relevant files (see patch) LGTM Joe, can you please give a look at this patch? Thanks Claudio

[rm7088_bristol.ac.uk, 2012-11-15 16:06:03]

Heya, Is there a reason that this change hasn't been merged? I'm happy to make any contributions that are needed but it all looks fine to me. Thanks, Rupert On Monday, July 18, 2011 7:21:38 PM UTC+1, Claudio Cherubino wrote: > > > > http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/cli... > File src/gdata/apps/emailsettings/client.py (right): > > > http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/cli... > src/gdata/apps/emailsettings/client.py:193: message to "Spam" if it > matches the specified filter criteria. > this should be "Trash" and not "Spam" > > > http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... > File src/gdata/apps/emailsettings/data.py (right): > > > http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... > src/gdata/apps/emailsettings/data.py:130: > looks like there is some extra whitespace here and below. > Did you run glint on the files? > > > http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... > src/gdata/apps/emailsettings/data.py:506: message to "Spam" if it > matches the specified filter criteria. > s/Spam/Trash > > > http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat... > src/gdata/apps/emailsettings/data.py:533: if forward_to is not None: > use: > > if forward_to: > > http://codereview.appspot.com/4702047/ > >