code review 4321045: os: fix FileInfo.Name returned by Stat

os: fix FileInfo.Name returned by Stat Fixes issue 1645.

[dforsyth, 2011-03-29 09:27:56]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

[rsc, 2011-03-29 14:03:45]

Looks pretty good. Thanks for fixing this. Please change CL description to os: fix FileInfo.Name returned by Stat It probably makes sense to move this code into file_unix.go so there's just one copy of it. Something like func lastElem(name string) string http://codereview.appspot.com/4321045/diff/3001/src/pkg/os/stat_darwin.go File src/pkg/os/stat_darwin.go (right): http://codereview.appspot.com/4321045/diff/3001/src/pkg/os/stat_darwin.go#new... src/pkg/os/stat_darwin.go:27: i := len(name) - 1 Please add comments. // Remove trailing slashes. and then on the next loop // Remove leading directory name. Also it would be good to avoid making the name "" instead of using the rewrite at the end, so that if it comes in as "" it doesn't turn into "/". It's easy: make the first loop say i > 0 and make the second loop start with an i--.

[dforsyth, 2011-03-29 17:37:25]

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

[dforsyth, 2011-03-29 18:04:55]

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

[rsc, 2011-03-29 18:17:26]

LGTM Thanks!

[rsc, 2011-03-29 18:23:40]

*** Submitted as http://code.google.com/p/go/source/detail?r=64a1547a5dc3 *** os: fix FileInfo.Name returned by Stat Fixes issue 1645. R=rsc CC=golang-dev http://codereview.appspot.com/4321045 Committer: Russ Cox <rsc@golang.org>