code review 4018041: http: Fixed implementation of chunked and ranged responses.

http: Fixed implementation of chunked and ranged responses. See RFC2616 sections 14.16, 4.4 2. and 4.4 3. Specifically MUST NOT send Content-Length when Transfer-Encoding != "identity". And Content-Range must be on form "bytes N_s-N_e/N_t" Where N_s and N_e is zero-indexed, while N_t is the one-indexed total length.

[clementskau, 2011-01-14 14:47:55]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

[rsc, 2011-01-18 19:58:53]

Thanks for tracking these down. Please make the fixes below and re-run hg mail 4018041. http://codereview.appspot.com/4018041/diff/2001/src/pkg/http/fs.go File src/pkg/http/fs.go (right): http://codereview.appspot.com/4018041/diff/2001/src/pkg/http/fs.go#newcode174 src/pkg/http/fs.go:174: // RFC2616 section 4.4 2. and 3.: please delete new comment. current code is correct especially for HEAD requests. let the http code do the right thing behind the scenes http://codereview.appspot.com/4018041/diff/2001/src/pkg/http/server.go File src/pkg/http/server.go (right): http://codereview.appspot.com/4018041/diff/2001/src/pkg/http/server.go#newcod... src/pkg/http/server.go:232: // RFC2616 section 4.4 2., 3.: Must not have both Transfer-Encoding and Content-Length. // Cannot have use Content-Length with non-identity Transfer-Encoding.

[clementskau, 2011-01-19 12:42:18]

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

[rsc, 2011-01-19 15:05:51]

*** Submitted as ac02197d4e1f *** http: fix Content-Range and Content-Length in response RFC2616 sections 4.4 and 14.16: * Cannot use Content-Length with non-identity Transfer-Encoding * Content-Range response is "bytes x-y/z" not "x-y/z" R=rsc CC=golang-dev http://codereview.appspot.com/4018041 Committer: Russ Cox <rsc@golang.org>