code review 39330043: go.tools/dashboard/builder: make template work with mer...

go.tools/dashboard/builder: make template work with mercurial 2.8 The current mercurial template fails with Mercurial 2.8 - 'escape' is not compatible with the 'parent' keyword. $ hg version | head -n 1 Mercurial Distributed SCM (version 2.8) $ hg log --limit=1 --template='{parent|escape}' abort: template filter 'escape' is not compatible with keyword 'parent' $ hg log --limit=1 --template='{parent}' 577:25a7477727f3

[jsing, 2013-12-10 13:22:24]

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

[dvyukov, 2013-12-10 13:34:40]

In hg 2.0.2 the field is called 'parents'. Are you sure it's 'parent' in your version? Does 'parents' work in your version?

[jsing, 2013-12-10 14:26:00]

On 2013/12/10 13:34:40, dvyukov wrote: > In hg 2.0.2 the field is called 'parents'. Are you sure it's 'parent' in your > version? Does 'parents' work in your version? In 2.8 '{parents}' just returns an empty value and '{parents|escape}' returns the same error as '{parent|escape}'. As an interesting aside, 2.0.2 seemingly returns nothing for both '{parent}' and '{parents}'.

[dvyukov, 2013-12-10 14:46:28]

On 2013/12/10 14:26:00, jsing wrote: > On 2013/12/10 13:34:40, dvyukov wrote: > > In hg 2.0.2 the field is called 'parents'. Are you sure it's 'parent' in your > > version? Does 'parents' work in your version? > > In 2.8 '{parents}' just returns an empty value and '{parents|escape}' returns > the same error as '{parent|escape}'. As an interesting aside, 2.0.2 seemingly > returns nothing for both '{parent}' and '{parents}'. Try to fetch more commits, because when the parent is the previous commits, it returns empty string.

[gobot, 2013-12-20 16:26:05]

Replacing golang-dev with golang-codereviews.

[adg, 2014-01-28 03:32:59]

LGTM

[bsiegert, 2014-02-26 14:46:32]

Ping.

[patrick2, 2014-02-26 18:29:50]

On 2014/02/26 14:46:32, bsiegert wrote: > Ping. What about : $ hg log -r . --template '{parent|stringify|escape}\n' 20454:f37761a226d9 Are you targeting only 2.8? I do not know how well this works for older versions.

[patrick2, 2014-02-26 18:57:20]

I tried this thing from 2.2 to 2.8 and it never worked. Best case you got empty output. The "parent" keyword filter is undocumented and probably some backward compatibility thing, defined as: {rev}:{node|formatnode} And "formatnode" is another internal function resolving to "short" for non --debug calls. So either use "parents", or "{rev}:{node|short}" or look at "hg help templating" depending on your needs.

[mpmselenic, 2014-02-26 20:06:41]

Just tested back to hg 1.0 - never did anything, now generates an error. Also note that |escape was always redundant. A decimal or hex revision id will never contain characters that need HTML escaping.

[gobot, 2014-12-19 05:17:41]

R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/39330043 is best) in the description in your new CL. Thanks very much.