Parties associated to open Leads and Opprtunities

Adds just like sales and purchase a new parties link Please review

[Paul J Stevens, 2010-10-26 13:59:57]

Looks like this is a patch against the 1.6 branch, correct?

[sharoonthomas, 2010-10-27 02:13:05]

Yes of course, on approval of this I could propose the 1.8 branch patch too. Tryton maintains last 3 releases and sale_opportunities is avalilable since 1.6 On 2010/10/26 13:59:57, Paul J Stevens wrote: > Looks like this is a patch against the 1.6 branch, correct?

[ced, 2010-10-27 06:11:53]

On 2010/10/27 02:13:05, sharoonthomas wrote: > Yes of course, on approval of this I could propose the 1.8 branch patch too. > > Tryton maintains last 3 releases and sale_opportunities is avalilable since 1.6 But any change of this kind will be applied on series.

[ced, 2010-11-11 17:09:02]

Please update it to trunk http://codereview.appspot.com/2736043/diff/1/opportunity.py File opportunity.py (right): http://codereview.appspot.com/2736043/diff/1/opportunity.py#newcode870 opportunity.py:870: Select distinct parties from the missing ending comment http://codereview.appspot.com/2736043/diff/1/opportunity.py#newcode880 opportunity.py:880: 'SELECT DISTINCT("party") FROM "%s" WHERE "state" IN ' + No need of "+" Could you reindent this way: SELECT DISCTINCT(party) FROM "%" WHERE state IN ('lead', 'opportunity') It is more readable to break on SQL statement like SELECT, FROM etc. http://codereview.appspot.com/2736043/diff/1/opportunity.xml File opportunity.xml (right): http://codereview.appspot.com/2736043/diff/1/opportunity.xml#newcode765 opportunity.xml:765: <record model="ir.action.wizard" id="act_open_lead_opportunity"> act_opened_lead_opportunity_party http://codereview.appspot.com/2736043/diff/1/opportunity.xml#newcode766 opportunity.xml:766: <field name="name">Parties associated to open Leads and Opportunities</field> "Opened Leads" to keep the same wording.