Issue 223085: Do not create more tickets while more than 10MB in messages is already uploading

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223085: Do not create more tickets while more than 10MB in messages is already uploading

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by Greg Robbins

Modified:
10 years, 10 months ago

Reviewers:
TVL, thomasvl

Base URL:
http://google-email-uploader-mac.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : comment changes #

Total comments: 2

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	Source/EmUpConstants.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	Source/EmUpWindowController.m	View	1	1 chunk	+8 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

http://codereview.appspot.com/223085/diff/1001/1003 File Source/EmUpWindowController.m (right): http://codereview.appspot.com/223085/diff/1001/1003#newcode1020 Source/EmUpWindowController.m:1020: NSNumber *totalUploadSizeNum = [uploadTickets_ valueForKeyPath:@"postedObject.uploadData.@sum.length"]; On 2010/03/01 21:52:06, thomasvl wrote: > sure this won't cause a problem like it did for gdata? It's infrequently called here (once per message uploading); it's not in the tight UI loop like in the outline view case

Expand All Messages | Collapse All Messages