Issue 212043: Add version check code; add Release Notes menu item

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 212043: Add version check code; add Release Notes menu item

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by Greg Robbins

Modified:
10 years, 10 months ago

Reviewers:
TVL

Base URL:
http://google-email-uploader-mac.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : add release notes #

Patch Set 3 : Use a separate LatestVersion.plist to avoid accidental Info.plist changes causing update messages #

Total comments: 4

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -12 lines)			Patch
M	Source/EmUpAppController.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/EmUpAppController.m	View	1 2	2 chunks	+115 lines, -4 lines	4 comments	Download
M	Source/English.lproj/Localizable.strings	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/English.lproj/MainMenu.xib	View		11 chunks	+49 lines, -3 lines	0 comments	Download
M	Source/Info.plist	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/ReleaseNotes.txt	View	2	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

http://codereview.appspot.com/212043/diff/12/15 File Source/EmUpAppController.m (right): http://codereview.appspot.com/212043/diff/12/15#newcode124 Source/EmUpAppController.m:124: NSString *urlStr = @"http://google-email-uploader-mac.googlecode.com/svn/trunk/Source/LatestVersion.plist"; On 2010/02/18 18:36:42, TVL wrote: > should this file be in this cl? Checked in separately (needed to check it in first for testing) http://code.google.com/p/google-email-uploader-mac/source/browse/trunk/Source... http://codereview.appspot.com/212043/diff/12/15#newcode182 Source/EmUpAppController.m:182: NSString *urlStr = @"https://code.google.com/p/google-email-uploader-mac/"; On 2010/02/18 18:36:42, TVL wrote: > how about https://code.google.com/p/google-email-uploader-mac/downloads/list so > there should only be one thing to download? (less things to kick on) I put that in initially, but changed it because the project home page also has a highlighted download link, and the downloads page seemed more potentially confusing if there was more than one download listed. But currently the downloads page is certainly less busy, though it lacks any "click here" kind of graphic. I'm torn.

Expand All Messages | Collapse All Messages