code review 195060043: compiler: Do not mark unused variables as used inside c...

compiler: Do not mark unused variables as used inside closures. Fixes golang/go#6415.

[cmang, 2015-01-12 21:55:07]

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend

[iant, 2015-01-12 23:17:41]

https://codereview.appspot.com/195060043/diff/60001/go/parse.cc File go/parse.cc (right): https://codereview.appspot.com/195060043/diff/60001/go/parse.cc#newcode2453 go/parse.cc:2453: !may_be_sink, location); I would rather just pass down may_be_sink, rather than negating it. Several functions take may_be_sink as a parameter; it seems less confusing to add another such function rather than introduce a new name.

[cmang, 2015-01-12 23:40:17]

https://codereview.appspot.com/195060043/diff/60001/go/parse.cc File go/parse.cc (right): https://codereview.appspot.com/195060043/diff/60001/go/parse.cc#newcode2453 go/parse.cc:2453: !may_be_sink, location); On 2015/01/12 23:17:41, iant wrote: > I would rather just pass down may_be_sink, rather than negating it. Several > functions take may_be_sink as a parameter; it seems less confusing to add > another such function rather than introduce a new name. Done.

[iant, 2015-01-20 21:24:13]

LGTM

[iant, 2015-01-20 21:28:39]

*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=00adc946a742 *** compiler: Do not mark unused variables as used inside closures. Fixes golang/go#6415. LGTM=iant R=iant CC=gofrontend-dev https://codereview.appspot.com/195060043 Committer: Ian Lance Taylor <iant@golang.org>