Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 185250043: code review 185250043: net/url: Handling invalid slashes after url scheme.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Emmanuel
Modified:
10 years, 10 months ago
CC:
golang-codereviews
Visibility:
Public.

Description

net/url: Handling invalid slashes after url scheme. Fixes issue 9216 and old tests.

Patch Set 1 #

Patch Set 2 : diff -r 586738173884643d0dca3fd844f73294984d0b9c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 586738173884643d0dca3fd844f73294984d0b9c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -2 lines) Patch
M src/net/url/url.go View 1 4 chunks +36 lines, -0 lines 0 comments Download
M src/net/url/url_test.go View 1 2 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Emmanuel
Hello golang-codereviews@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 10 months ago (2014-12-10 23:44:14 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
10 years, 10 months ago (2014-12-10 23:45:58 UTC) #2
bradfitz
R=close We have moved to Git and Gerrit. The new contributing instructions are at http://godoc-test.golang.org/doc/contribute.html ...
10 years, 10 months ago (2014-12-11 01:14:13 UTC) #3
rsc
10 years, 10 months ago (2014-12-11 01:56:11 UTC) #4
Please do NOT send this review with git-review. We are not ready for external users to do that. Just wait. Brad, I'm going to close every CL on the dashboard with a message like yours, once the tree is actually open for real work. Russ 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b