Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(238)

Issue 179840043: code review 179840043: cmd/dist: reenable hardware fp support on freebsd/arm

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by dave
Modified:
10 years, 10 months ago
Reviewers:
minux
CC:
rsc, minux, golang-codereviews
Visibility:
Public.

Description

cmd/dist: reenable hardware fp support on freebsd/arm VFP support used to be so broken on freebsd/arm that it would lock up the kernel if you even tried to execute a VFP instruction. This has since been fixed and the builder I have has working floating point support so we can remove this workaround.

Patch Set 1 #

Patch Set 2 : diff -r 87c336dbef0b014e021dc5c2c4c16448f036249b https://code.google.com/p/go #

Patch Set 3 : diff -r 87c336dbef0b014e021dc5c2c4c16448f036249b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/cmd/dist/arm.c View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5
dave_cheney.net
Hello rsc@golang.org, minux@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 11 months ago (2014-11-17 03:30:26 UTC) #1
rsc
not now
10 years, 11 months ago (2014-11-17 03:36:18 UTC) #2
dave_cheney.net
understood On Mon, Nov 17, 2014 at 2:36 PM, Russ Cox <rsc@golang.org> wrote: > not ...
10 years, 11 months ago (2014-11-17 03:39:59 UTC) #3
minux
does FreeBSD support disabling the VFP runfast (flush-to-zero) mode yet? (Clearing VFPSCR_FZ in FPSCR) Last ...
10 years, 11 months ago (2014-11-17 04:39:45 UTC) #4
gobot
10 years, 10 months ago (2014-12-19 05:16:52 UTC) #5
R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/179840043 is best) in the description in your new CL. Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b