code review 169810043: watcher: fall back to GCE metadata service for the mast...

watcher: fall back to GCE metadata service for the master builder key

[hightower, 2014-10-30 21:04:26]

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools/

[bradfitz, 2014-10-30 21:48:12]

LGTM but see comment https://codereview.appspot.com/169810043/diff/40001/dashboard/watcher/watcher.go File dashboard/watcher/watcher.go (right): https://codereview.appspot.com/169810043/diff/40001/dashboard/watcher/watcher... dashboard/watcher/watcher.go:598: Transport: &http.Transport{ you should add "DisableKeepAlives: true" to this Transport too, since this is leaking the Transport on every call and Transport keeps background goroutines running unless you set that. feel free to fix the other case in this CL too if you'd like.

[bradfitz, 2014-11-12 17:53:17]

Status of this?

[hightower, 2014-11-12 19:20:30]

On 2014/11/12 17:53:17, bradfitz wrote: > Status of this? I'm going to wrap this up between today and tomorrow.

[gobot, 2014-12-19 05:15:34]

R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/169810043 is best) in the description in your new CL. Thanks very much.