Issue 166260043: Remove permessage-compress extension support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166260043: Remove permessage-compress extension support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by tyoshino (chromium.org)

Modified:
10 years, 12 months ago

Reviewers:
yhirano, Yutaka Hirano

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove permessage-compress extension support Release note: Remove permessage-compress extension support R=yhirano@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=860

Patch Set 1 #

Patch Set 2 : Add missing implementation change #

Patch Set 3 : #

Patch Set 4 : Addressed #3 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -290 lines)			Patch
M	src/mod_pywebsocket/common.py	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/mod_pywebsocket/extensions.py	View	1 2	4 chunks	+6 lines, -127 lines	0 comments	Download
M	src/test/test_extensions.py	View		2 chunks	+0 lines, -81 lines	0 comments	Download
M	src/test/test_handshake_hybi.py	View	1	8 chunks	+22 lines, -35 lines	0 comments	Download
M	src/test/test_msgutil.py	View		5 chunks	+27 lines, -33 lines	0 comments	Download
M	src/test/test_mux.py	View		6 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r860 (presubmit successful).

Expand All Messages | Collapse All Messages