code review 166059: This patch enables cgo utility to correctly convert enu...

This patch enables cgo utility to correctly convert enums in the C source into consts in the resulting Go source. Previously known as issue 161047, which I deleted accidentally. Fixes issue 207.

[mozo, 2009-12-04 15:59:25]

Hello rsc, I'd like you to review the following change.

[rsc, 2009-12-07 18:20:23]

this looks good to me. please make the one change below and re-run hg sync / hg upload and then ping this thread. also, i see that you've edited the CONTRIBUTORS file but not the AUTHORS file. there should be a corresponding change to the AUTHORS file and you need to complete a CLA for your first change. see http://golang.org/doc/contribute.html#copyright http://codereview.appspot.com/166059/diff/1001/14 File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/166059/diff/1001/14#newcode134 src/cmd/cgo/gcc.go:134: default: default: break is implied. delete

[mozo, 2009-12-12 02:51:00]

Hello rsc, I'd like you to review the following change.

[rsc, 2009-12-14 04:03:25]

http://codereview.appspot.com/166059/diff/3014/4008 File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/166059/diff/3014/4008#newcode134 src/cmd/cgo/gcc.go:134: default: Sorry, I meant to delete the "default:" case too.

[mozo, 2009-12-14 09:19:00]

Hello rsc, I'd like you to review the following change.

[rsc, 2009-12-16 05:19:06]

LGTM Thanks. You should probably cd $GOROOT hg revert src/cmd/cgo before running hg sync We stripped the semicolons today in gofmt, so the patch I apply won't match your client; the revert will avoid a merge conflict.

[rsc, 2009-12-16 05:24:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=114e1205429b *** This patch enables cgo utility to correctly convert enums in the C source into consts in the resulting Go source. Previously known as issue 161047, which I deleted accidentally. Fixes issue 207. R=rsc http://codereview.appspot.com/166059 Committer: Russ Cox <rsc@golang.org>