Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(762)

Issue 157094: code review 157094: Package log now contains a useful interface and functi...

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 11 months ago by jimi_hendrix
Modified:
1 year, 11 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

Package log now contains a useful interface and functions to act on it. The package now includes an interface that can be implemented for the logger object to log the implementing object. Also added two helper functions for this feature that log to stdout and stderr. Tests were also added for this feature for use during build.

Patch Set 1 #

Patch Set 2 : code review 157094: Package log now contains a useful interface and functi... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -12 lines) Patch
M src/pkg/Make.deps View 1 4 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/log/log.go View 3 chunks +12 lines, -0 lines 0 comments Download
M src/pkg/log/log_test.go View 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3
jimi_hendrix
Hello golang-dev@googlegroups.com, I'd like you to review the following change.
15 years, 11 months ago (2009-11-19 23:35:27 UTC) #1
rsc
Thanks but no thanks. If you want to make an object loggable, I suggest putting ...
15 years, 10 months ago (2009-12-11 19:48:45 UTC) #2
rsc
15 years, 10 months ago (2009-12-11 19:49:36 UTC) #3
 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b