Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(141)

Issue 150090043: cloud: Adding a user-agent to the outgoing request

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by jbd
Modified:
11 years, 1 month ago
Reviewers:
adg
CC:
veneer-firehose_google.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -6 lines) Patch
M compute/metadata/metadata.go View 2 chunks +10 lines, -6 lines 0 comments Download
A internal/cloud.go View 1 1 chunk +62 lines, -0 lines 2 comments Download
M storage/storage.go View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jbd
11 years, 1 month ago (2014-09-25 19:46:54 UTC) #1
adg
https://codereview.appspot.com/150090043/diff/1/internal/cloud.go File internal/cloud.go (right): https://codereview.appspot.com/150090043/diff/1/internal/cloud.go#newcode39 internal/cloud.go:39: // TODO(jbd): Is it OK to mutate request? UATransport ...
11 years, 1 month ago (2014-09-26 02:53:00 UTC) #2
jbd
PTAL
11 years, 1 month ago (2014-09-26 08:55:39 UTC) #3
adg
LGTM https://codereview.appspot.com/150090043/diff/20001/internal/cloud.go File internal/cloud.go (right): https://codereview.appspot.com/150090043/diff/20001/internal/cloud.go#newcode15 internal/cloud.go:15: // Package internal provides support for package cloud. ...
11 years, 1 month ago (2014-09-28 22:48:25 UTC) #4
jbd
11 years, 1 month ago (2014-09-29 01:11:31 UTC) #5
Submitted. https://codereview.appspot.com/150090043/diff/20001/internal/cloud.go File internal/cloud.go (right): https://codereview.appspot.com/150090043/diff/20001/internal/cloud.go#newcode15 internal/cloud.go:15: // Package internal provides support for package cloud. On 2014/09/28 22:48:25, adg wrote: > s/package cloud/the cloud packages/ Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b