Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(93)

Issue 145730043: code review 145730043: syscall: undo CL 119530044

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
10 years, 10 months ago
Reviewers:
r, dsymonds, bradfitz
CC:
bradfitz, r, dsymonds, golang-codereviews
Visibility:
Public.

Description

syscall: undo CL 119530044 That CL worked around a bug present in the OS X Yosemite Public Beta versions 1 and 2. Beta 3 (released today) has fixed the bug. Fixes issue 8423.

Patch Set 1 #

Patch Set 2 : diff -r b18ebcb9f2367d52af8c3515dee63888ca96db70 https://code.google.com/p/go #

Patch Set 3 : diff -r b18ebcb9f2367d52af8c3515dee63888ca96db70 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M src/syscall/syscall_bsd.go View 1 1 chunk +1 line, -34 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello bradfitz, r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2014-09-16 02:36:00 UTC) #1
dsymonds
LGTM woo!
11 years, 1 month ago (2014-09-16 02:41:50 UTC) #2
bradfitz
LGTM Hopping on the yay train! Now can they fix the profiling bug? :)
11 years, 1 month ago (2014-09-16 11:52:37 UTC) #3
r
LGTM
11 years, 1 month ago (2014-09-16 16:04:20 UTC) #4
r
go.sys has the same temporary fix. on my list. On Tue, Sep 16, 2014 at ...
11 years, 1 month ago (2014-09-16 16:05:48 UTC) #5
gobot
10 years, 10 months ago (2014-12-19 05:13:30 UTC) #6
R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/145730043 is best) in the description in your new CL. Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b