rpc: add notifications

rpc: add notifications This will allow us to selectively log rpc requests. https://code.launchpad.net/~rogpeppe/juju-core/447-rpc-log-filter/+merge/190483 (do not edit description out of merge proposal)

[rog, 2013-10-11 07:08:09]

Please take a look.

[axw, 2013-10-11 07:30:17]

LGTM https://codereview.appspot.com/14531048/diff/1/rpc/server.go File rpc/server.go (right): https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode139 rpc/server.go:139: // as that cause delays to the RPC server or deadlock. as that ____ cause? https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode140 rpc/server.go:140: type RequestNotifier interface { Might be worthwhile adding a note that the methods must be goroutine-safe. https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode367 rpc/server.go:367: if conn.notifier != nil { Does this not want to be called regardless of whether the body was read?

[rog, 2013-10-11 09:17:42]

Please take a look. https://codereview.appspot.com/14531048/diff/1/rpc/server.go File rpc/server.go (right): https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode139 rpc/server.go:139: // as that cause delays to the RPC server or deadlock. On 2013/10/11 07:30:18, axw wrote: > as that ____ cause? Done. https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode140 rpc/server.go:140: type RequestNotifier interface { On 2013/10/11 07:30:18, axw wrote: > Might be worthwhile adding a note that the methods must be goroutine-safe. Done. https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode367 rpc/server.go:367: if conn.notifier != nil { On 2013/10/11 07:30:18, axw wrote: > Does this not want to be called regardless of whether the body was read? Done.