Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1466)

Issue 14081: Update for GData changes

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by stuart.morgan
Modified:
10 years, 10 months ago
Reviewers:
TVL
Base URL:
http://calaboration.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes the project for GData re-org, and removes references to a constant that no longer exists. Adds a user agent now that GData complains in the console if there isn't one. It appears that the GData update somehow changes the the calendar ID URLs that we get back ("calendars" instead of "allcalendars" IIRC), so I made the parsing more generic.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated to construct UA correctly (and adding a missing CFBundleShortVersionString) #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -58 lines) Patch
M ApplicationController.m View 1 3 chunks +10 lines, -9 lines 0 comments Download
M Calaboration.xcodeproj/project.pbxproj View 1 17 chunks +58 lines, -48 lines 2 comments Download
M Info.plist View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
stuart.morgan
16 years, 8 months ago (2009-02-12 04:37:43 UTC) #1
TVL
http://codereview.appspot.com/14081/diff/1/2 File ApplicationController.m (left): http://codereview.appspot.com/14081/diff/1/2#oldcode314 Line 314: [accessLevel isEqualToString:kGDataCalendarAccessContributor] || wasn't this the one we ...
16 years, 8 months ago (2009-02-13 13:44:04 UTC) #2
stuart.morgan
16 years, 8 months ago (2009-02-17 23:26:15 UTC) #3
TVL
16 years, 8 months ago (2009-02-18 01:26:13 UTC) #4
lgtm http://codereview.appspot.com/14081/diff/1003/9 File Calaboration.xcodeproj/project.pbxproj (right): http://codereview.appspot.com/14081/diff/1003/9#newcode843 Line 843: PRODUCT_VERSION = 1.0.2; 1.0.3 since you have other changes too? http://codereview.appspot.com/14081/diff/1003/9#newcode857 Line 857: PRODUCT_VERSION = 1.0.2; ditto
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b