code review 1395041: goinstall: Use 'git pull' instead of 'git checkout' whe...

goinstall: Use 'git pull' instead of 'git checkout' when updating a git repo.

[hoisie, 2010-05-28 21:22:06]

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

[hoisie, 2010-05-28 21:30:07]

'git checkout' is used to switch branches in a repo. It doesn't actually incorporate the changes. You need a combination of 'git fetch' and 'git merge', which is what 'git pull does'. Ideally it would be 'git pull --rebase', which helps if you have local changes. On 2010/05/28 21:22:06, hoisie wrote: > Hello rsc (cc: mailto:golang-dev@googlegroups.com), > > I'd like you to review this change.

[rsc, 2010-05-28 21:31:41]

LGTM On Fri, May 28, 2010 at 14:22, <hoisie@gmail.com> wrote: > Reviewers: rsc, > > Message: > Hello rsc (cc: golang-dev@googlegroups.com), > > I'd like you to review this change. > > > Description: > goinstall: Use 'git pull' instead of 'git checkout' when updating a git > repo. > > Please review this at http://codereview.appspot.com/1395041/show > > Affected files: >  M src/cmd/goinstall/download.go > > > Index: src/cmd/goinstall/download.go > =================================================================== > --- a/src/cmd/goinstall/download.go > +++ b/src/cmd/goinstall/download.go > @@ -102,7 +102,7 @@ >        cmd:            "git", >        metadir:        ".git", >        clone:          "clone", > -       update:         "checkout", > +       update:         "pull", >        pull:           "fetch", >        log:            "log", >        logLimitFlag:   "-n1", > > > 

[rsc, 2010-06-01 21:27:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=d0adafd98693 *** goinstall: Use 'git pull' instead of 'git checkout' when updating a git repo. R=rsc CC=golang-dev http://codereview.appspot.com/1395041 Committer: Russ Cox <rsc@golang.org>